Improves IME ESC key handling #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small update. It basically keeps the original implementation in 88185ee, but the condition of clearing the textbox is changed: only if
HandleEscapeKey()returns false, i.e., this user has never used IME.Explanation:
To make this judgement acts correctly, this PR intends to remove
IMEEventReceived = trueline inOnIMETextInput()method, as this method will also be called even if the user does not use an Asian IME.Tested on my machine.