Open
Conversation
serprex
changed the title
serprex
commented
May 7, 2026
Comment on lines
+269
to
+270
| * Jagged shape: format as text and route through array_in so | ||
| * binary surfaces the same malformed-literal error as http. |
Member
Author
There was a problem hiding this comment.
this might be overkill, other option is to just raise error that array is jagged
Collaborator
There was a problem hiding this comment.
Love consistent error messages!
theory
added
data types
serprex
force-pushed
the
multidimensonal-arrays
branch
3 times, most recently
from
9cf1c6a to
075ca77
Compare
theory
requested changes
May 8, 2026
Collaborator
There was a problem hiding this comment.
Great, but I think there are some leftovers, like this in convert.c starting at line 637:
if (AARR_NDIM(v) > 1)
ereport(ERROR,
(errcode(ERRCODE_DATATYPE_MISMATCH),
errmsg("pg_clickhouse: inserted array should have one dimension")));And this in deparse.c at line 2086:
if (ndims > 1)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("only one dimension of arrays supported by pg_clickhouse")));I presume these are no longer relevant, yes?
Also: Please note improvement in CHANGELOG.md.
Comment on lines
+269
to
+270
| * Jagged shape: format as text and route through array_in so | ||
| * binary surfaces the same malformed-literal error as http. |
Collaborator
There was a problem hiding this comment.
Love consistent error messages!
Member
Author
|
those checks were still relevant because INSERT didn't support multi-dimensional. updated PR to support that |
serprex
force-pushed
the
multidimensonal-arrays
branch
from
cbdafed to
8d9a7f8
Compare
needed for functions like extractAllGroupsHorizontal returning Array(Array(String))
serprex
force-pushed
the
multidimensonal-arrays
branch
from
8d9a7f8 to
dbf407d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for functions like extractAllGroupsHorizontal returning Array(Array(String))