Open
Conversation
theory
added
data types
theory
force-pushed
the
binary-json
branch
4 times, most recently
from
856e069 to
6e1678e
Compare
serprex
approved these changes
May 6, 2026
theory
force-pushed
the
binary-json
branch
6 times, most recently
from
3793684 to
4c7432f
Compare
Update the clickhouse-cpp submodule to f067937, which adds JSON support from ClickHouse/clickhouse-cpp#490. Works on ClickHouse 24.10 and higher for the `output_format_native_write_json_as_string` setting, pass the client to `ch_binary_settings()` and check the server version. Add the mappings to `src.binary.cpp` following the usual pattern. Always convert the ClickHouse JSON to `jsonb` for now; will need to change how the type OID is passed to `make_datum` before we can properly support `json`; will fix in a forthcoming commit. Update the tests to ensure that the binary-backed and http-backed JSONB mappings generate the same remote queries and return the same results. While about things, fix the broken CluckHouse Tutorial links in `doc/tutorial.md` and add move `clang-format` to `dev/indent.sh` so that it runs as part of the pre-commit config, and thus also `make lint` and the "🔎 Lint" workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ClickHouse/clickhouse-cpp#490, here by updating the clickhouse-cpp submodule. Works on ClickHouse 24.10 and higher for the
output_format_native_write_json_as_stringsetting, pass the client toch_binary_settings()and check the server version.Update the clickhouse-cpp submodule to f067937, which adds JSON support from ClickHouse/clickhouse-cpp#490. Works on ClickHouse 24.10 and higher for the
output_format_native_write_json_as_stringsetting, pass the client toch_binary_settings()and check the server version.Update the tests to ensure that the binary-backed and http-backed JSONB mappings generate the same remote queries and return the same results.
While about things, fix the broken CluckHouse Tutorial links in
doc/tutorial.mdand add moveclang-formattodev/indent.shso that it runs as part of the pre-commit config, and thus alsomake lintand the "🔎 Lint" workflow.