fix: pagination mobile layout and responsive story preview#1014
Draft
natalyjazzviolin wants to merge 13 commits intomainfrom
Draft
fix: pagination mobile layout and responsive story preview#1014natalyjazzviolin wants to merge 13 commits intomainfrom
natalyjazzviolin wants to merge 13 commits intomainfrom
Conversation
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 6b2b8c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Contributor
Author
|
@claude[agent] review this PR |
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Co-authored-by: Nataly Merezhuk <natalyjazzviolin@users.noreply.github.com>
Contributor
📚 Storybook Preview Deployed✅ Preview URL: https://click-qte2j0c21-clickhouse.vercel.app Built from commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Pagination switched parts of its layout to column mode on small screens, causing labels and controls (like
19 rows/of 2) to stack vertically instead of preserving desktop structure. There was also a mobile regression where the page number input could stretch wider than intended in some layouts.How?
NoWrapTextcomponent inPagination.tsx.width: clamp(44px, calc(<digitCount>ch + 2.5rem), 72px)) withflex: 0 0 auto, so the input remains compact, can grow slightly for larger page counts, and avoids both stretching and collapsing on mobile.@clickhouse/click-ui.Playgroundstory only.Pagination.responsive.test.tsxper request and kept functional Pagination tests inPagination.test.tsx.Tickets?
Contribution checklist?
buildcommand runs locallySecurity checklist?
dangerouslySetInnerHTMLPreview?
VM previews captured during verification:
/opt/cursor/artifacts/pagination-vm-preview.webm/opt/cursor/artifacts/pagination-vm-preview-fixed.webm/opt/cursor/artifacts/pagination-vm-preview-fixed-nowrap.webm/opt/cursor/artifacts/pagination-vm-preview-all-inline.webm