Add floating point time support to pmodel cb#1642
Open
imreddyTeja wants to merge 2 commits intomainfrom
Open
Conversation
imreddyTeja
force-pushed
the
tr/pmodel-fttime
branch
from
1baa2aa to
eb5915f
Compare
imreddyTeja
force-pushed
the
tr/pmodel-fttime
branch
from
eb5915f to
24e84b9
Compare
imreddyTeja
changed the title
imreddyTeja
commented
Mar 3, 2026
| @@ -1474,8 +1501,15 @@ and not for the conductance component(PModelConductance). | |||
|
|
|||
| Note that the Δt passed here is an ITime because it is the Δt used in the simulation. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add a constructor for the PModel cb that works with floating point time
To-do
Content