Fix syncing of reset completion info #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset completion info for quest progress update from server (cherry picked from commit GTNewHorizons/BetterQuesting@06adce0) Fix bug with partial quests progress updates will not reset quest completion info on client (cherry picked from commit GTNewHorizons/BetterQuesting@57919c0) Co-Authored-By: Glease <[email protected]> Co-Authored-By: SKProCH <[email protected]>
WaitingIdly
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes repeatable quests not being automatically synced upon completion. Just a cherry-pick from GTNH's fork. Future improvements can be made to resync per-quest id instead of the force resync here if necessary. I quickly tested a simple repeatable quest on a dedicated server and can verify it resets automatically soon after claiming.
Fixes #107.