fix: allow sending messages when QuickPanel is open with @ in content#14102
Open
404-Page-Found wants to merge 1 commit intoCherryHQ:v2from
Open
fix: allow sending messages when QuickPanel is open with @ in content#14102404-Page-Found wants to merge 1 commit intoCherryHQ:v2from
404-Page-Found wants to merge 1 commit intoCherryHQ:v2from
Conversation
When the QuickPanel was visible and user pressed Enter (e.g., to send a message containing @), the panel would incorrectly intercept the Enter key to select items from the list instead of allowing the message to be sent. This caused the last selected model to be deselected when multiple models were called. This fix changes the Enter key behavior in QuickPanelView to: - Close the panel when plain Enter is pressed - Allow the event to propagate to the input field for message sending - Preserve the search text after closing (by adding 'enter' to exclusion list) Fixes CherryHQ#14085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
When the QuickPanel was visible and user pressed Enter (e.g., to send a message containing @), the panel incorrectly intercepted the Enter key to select items from the list instead of allowing the message to be sent. This caused the last selected model to be deselected when multiple models were called.
After this PR:
The Enter key behavior in QuickPanelView now:
Fixes #14085
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place: N/A
Breaking changes
N/A
Special notes for your reviewer
N/A
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note