fix: prevent file processing crash and duplicate on long text paste#315
Open
chengcheng84 wants to merge 4 commits intoCherryHQ:mainfrom
Open
fix: prevent file processing crash and duplicate on long text paste#315chengcheng84 wants to merge 4 commits intoCherryHQ:mainfrom
chengcheng84 wants to merge 4 commits intoCherryHQ:mainfrom
Conversation
Add ref to track processing state and skip duplicate processing of the same text input
Collaborator
|
Potential race in |
eeee0717
reviewed
Feb 24, 2026
| } else { | ||
| // Fallback on error - keep the text | ||
| setTextInternal(newText) | ||
| } finally { |
Collaborator
There was a problem hiding this comment.
可按下面方式修复,避免旧请求把新请求的 guard 清掉:
} finally {
if (processingTextRef.current === newText) {
processingTextRef.current = null
}
}这样在 A、B 并发时,只有仍持有当前 guard 的那次调用才会清空,setText(B) 不会在 B 处理中被误放行。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #314 #235
修复之后发现,文本会被粘贴为2个文件