feat: add progressive types#528
Open
wemeetagain wants to merge 2 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dca3c9673b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+305
to
+306
| case "data": | ||
| return this.representativeType; |
There was a problem hiding this comment.
data path typing
Returning this.representativeType for getPropertyType("data") makes nested proof-path resolution incorrect when a CompatibleUnion is embedded in parents that still use getPathInfo traversal (e.g. StableContainerType.tree_createProofGindexes in packages/ssz/src/type/stableContainer.ts:434). In that flow, a path like ["unionField", "data", "newField"] is validated against the representative option instead of the active selector, so proofs for selector-specific fields throw Unknown ... property or resolve the wrong subtree even though CompatibleUnion.tree_createProofGindexes itself supports selector-aware traversal.
Useful? React with 👍 / 👎.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ProgressiveList,ProgressiveBitlist,ProgressiveContainer,CompatibleUnion