Skip to content

chore: update bootnode ENR with correct IPV6#8705

Merged
wemeetagain merged 3 commits intoChainSafe:unstablefrom
chiemerieezechukwu:patch-1
Dec 18, 2025
Merged

chore: update bootnode ENR with correct IPV6#8705
wemeetagain merged 3 commits intoChainSafe:unstablefrom
chiemerieezechukwu:patch-1

Conversation

@chiemerieezechukwu
Copy link
Copy Markdown
Contributor

Motivation

This PR is to fix eth-clients/mainnet#13

Already created this as well eth-clients/mainnet#14

Closes #issue_number

AI Assistance Disclosure

@chiemerieezechukwu chiemerieezechukwu requested a review from a team as a code owner December 17, 2025 23:17
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @chiemerieezechukwu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and connectivity of the mainnet by correcting an IPv6 address within a critical bootnode Entry Node Record (ENR). The update ensures that clients can accurately discover and connect to this bootnode, resolving a previously identified issue where the ENR contained an erroneous IPv6 address. This fix is crucial for maintaining robust peer discovery within the network.

Highlights

  • Bootnode ENR Update: Updated a specific bootnode Entry Node Record (ENR) in the mainnet configuration to include the correct IPv6 address.
  • Issue Resolution: This change directly addresses and fixes an existing issue related to an incorrect IPv6 configuration for a bootnode, ensuring proper network discovery.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a bootnode ENR for mainnet to correct an IPv6 address. The change is correct, but I noticed that a test file, packages/cli/test/unit/util/parseBootnodesFile.test.ts, still contains the old ENR. This should be updated to keep the tests in sync with the configuration. I've left a specific comment on the change with more details.

@chiemerieezechukwu chiemerieezechukwu changed the title Update bootnode ENR with correct IPV6 fix: update bootnode ENR with correct IPV6 Dec 17, 2025
@nflaig nflaig changed the title fix: update bootnode ENR with correct IPV6 chore: update bootnode ENR with correct IPV6 Dec 18, 2025
Copy link
Copy Markdown
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ENR looks good to me, but should be updating tests as noted by the AI

@nflaig
Copy link
Copy Markdown
Member

nflaig commented Dec 18, 2025

what about the hoodi enr? eth-clients/hoodi#24

@chiemerieezechukwu
Copy link
Copy Markdown
Contributor Author

what about the hoodi enr? eth-clients/hoodi#24

Fixed the test according to the AI and added the Hoodi bootnode ENR as well

Copy link
Copy Markdown
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wemeetagain wemeetagain merged commit 882891d into ChainSafe:unstable Dec 18, 2025
24 of 26 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.12%. Comparing base (f4236af) to head (e44015b).
⚠️ Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #8705      +/-   ##
============================================
- Coverage     52.12%   52.12%   -0.01%     
============================================
  Files           848      848              
  Lines         64948    64947       -1     
  Branches       4783     4783              
============================================
- Hits          33853    33852       -1     
  Misses        31026    31026              
  Partials         69       69              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wemeetagain
Copy link
Copy Markdown
Member

🎉 This PR is included in v1.39.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lodestar bootnode with local IPV6 address

4 participants