Skip to content

Conversation

@hongquanli
Copy link
Collaborator

  • Add [flatfield] optional dependency group
  • Install basicpy from QI2lab/BaSiCPy GitHub repo
  • Include matplotlib for flatfield visualization
  • Update [all] to include flatfield

🤖 Generated with Claude Code

- Add [flatfield] optional dependency group
- Install basicpy from QI2lab/BaSiCPy GitHub repo
- Include matplotlib for flatfield visualization
- Update [all] to include flatfield

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@hongquanli hongquanli merged commit 81a60e4 into main Jan 5, 2026
1 of 5 checks passed
hongquanli added a commit that referenced this pull request Jan 5, 2026
Allow direct Git references in optional dependencies by setting
tool.hatch.metadata.allow-direct-references = true

Fixes CI failure in PR #14

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
hongquanli added a commit that referenced this pull request Jan 5, 2026
hongquanli added a commit that referenced this pull request Jan 5, 2026
* Add flatfield optional dependency with QI2lab/BaSiCPy

- Add [flatfield] optional dependency group
- Install basicpy from QI2lab/BaSiCPy GitHub repo
- Include matplotlib for flatfield visualization
- Update [all] to include flatfield

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* Fix hatchling direct reference error for BaSiCPy

Allow direct Git references in optional dependencies by setting
tool.hatch.metadata.allow-direct-references = true

Fixes CI failure in PR #14

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
hongquanli added a commit that referenced this pull request Jan 5, 2026
- Fix #8: Update docstring to clarify dtype casting behavior (may clip)
- Fix #14: Add OSError handling in load_flatfield for file access errors
- Fix #16: Sync flatfield checkbox state with loaded/cleared status

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
hongquanli added a commit that referenced this pull request Jan 5, 2026
- Fix #2: Use os.startfile on Windows instead of shell=True
- Fix #7: Add comment about private method tf._read_tile usage
- Fix #11 & #14: Add explicit clipping before dtype cast for integer types
- Fix #12: Update docstring to accurately describe clipping behavior
- Fix #13: Add comment explaining intentional no-flatfield for raw sampling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants