fix: live illumination switching w/ hardware trigger #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in the illumination control logic where switching microscope modes would turn off the wrong illumination source. The fix ensures that the correct illumination channel is deactivated during mode transitions and adds defensive checks to prevent errors when no configuration is set.
Key changes:
- Reordered operations in
set_microscope_modeto turn off illumination before updating the configuration reference, ensuring the MCU's illumination_source points to the correct channel - Added None checks in
turn_on_illuminationandturn_off_illuminationto handle cases where no configuration is set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the illumination control logic in
live_controller.pyby ensuring that illumination functions handle cases where the current configuration is not set, and by correctly sequencing illumination shutdown during mode changes. These updates help prevent errors and ensure that the correct illumination source is turned off when switching microscope modes.Improvements to illumination control logic:
self.currentConfigurationbeingNonein bothturn_on_illuminationandturn_off_illuminationto prevent errors when no configuration is set. [1] [2]set_microscope_modeto turn off illumination before updatingself.currentConfiguration, ensuring the correct illumination source is deactivated when changing modes.