Implement provider for azure blob storage#466
Conversation
679b0fd to
7e0a94b
Compare
|
@felliott could you please help review my changes for azure blob storage? |
7e0a94b to
ca6525b
Compare
ca6525b to
3b6fdc0
Compare
|
I've merged |
Thank you so much for your help. The PR now only includes the changes related to Azure Blob, which makes it much clearer. |
|
@felliott Could you help review it today? We'd like to start end-to-end testing for this feature in the staging environment as soon as possible. |
felliott
left a comment
There was a problem hiding this comment.
Looks good! Great job on the test suite, you did an excellent job on making them comprehensive and understandable. I have a few small questions and nitpicks, but nothing too substantive. There are a few small flake errors that will prevent CI from running, but once those are fixed, i think it's good to merge. Thank you!
Cheers,
@felliott
61304c7 to
562e9d8
Compare
1e39d08
into
CenterForOpenScience:feature/azure-blob-storage
Ticket
NII Feature development Waterbutler
#44
Purpose
Add Azure Blob Storage provider support to WaterButler with OAuth2 authentication and full CRUD operations.
Changes
.osfkeepfilesSide effects
None. New provider implementation does not affect existing providers.
QA Notes
Deployment Notes