Removes v0, redirect downloads#355
Open
NyanHelsing wants to merge 9 commits intoCenterForOpenScience:developfrom
Open
Removes v0, redirect downloads#355NyanHelsing wants to merge 9 commits intoCenterForOpenScience:developfrom
NyanHelsing wants to merge 9 commits intoCenterForOpenScience:developfrom
Conversation
Removes all v0 files. these endpoints now return 410 (gone), except for the download action, which rewrites the url to return a redirect to the v1 api endpoint. We may consider writing an nginx directive to handle this as it would be far faster.
Removes some unused imports and adds in a slash that was missiong from the url being redirected to.
Only v0 uses the fetch method on the auth handler. v1 uses the get method. This removes the fetch method and the tests for it.
validate_path is only used by v0, so by removing v0, we can remove validate_path as well. validate_v1_path also gets renamed validate_path to cut down any confusion about the naming
Some tests only tested validate_path, which has been removed, so these tests were removed. Other tests needed to be updated so that they were mocked correctly because validate_v1_path (now `validate_path`) makes network requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-680
Purpose / Changes
Removes all v0 files. these endpoints now return 410 (gone), except for
the download action, which rewrites the url to return a redirect to the v1 api endpoint.
Side effects
v0 will no longer work
QA Notes
Check the redirects function properly
Deployment Notes
We may consider writing an nginx directive to handle this as it would be
far faster and lets WaterButler focus on moving forward, removing deprecated code completely.