Skip to content

External frontend url#3429

Open
vuorioma wants to merge 2 commits intomasterfrom
external-frontend-url
Open

External frontend url#3429
vuorioma wants to merge 2 commits intomasterfrom
external-frontend-url

Conversation

@vuorioma
Copy link
Collaborator

Checklist for author

#3402

  • Added the :external-frontend-url configuration option. This is used to override the url in outbound emails for use cases where REMS is used in conjuction with an external frontend application.

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Note if PR is on top of other PR
  • Note if related change in rems-deploy repo
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible or completely new
  • Events are backwards compatible or have migrations
  • Config is backwards compatible
  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI
  • Components are added to guide page
  • Update docs/ (if applicable)
  • Update manual/ (if applicable)
  • ADR for major architectural decisions or experiments
  • New config options in config-defaults.edn

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

  • New tasks are created for pending or remaining tasks

Copy link
Collaborator

@pikariop pikariop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the changes locally, seems to work. The config key should be added to resources/config-defaults.edn to avoid a warning on startup. Ready to merge once the checklist is updated and the new key is present in config-defaults.edn.

;; TODO list of resources?
;; TODO use real name when addressing user?

(defn url [] (or (not-empty (:external-frontend-url env)) (:public-url env)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could call this function

Suggested change
(defn url [] (or (not-empty (:external-frontend-url env)) (:public-url env)))
(defn base-url [] (or (not-empty (:external-frontend-url env)) (:public-url env)))

to be a bit more specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants