Conversation
pikariop
approved these changes
Feb 24, 2026
Collaborator
pikariop
left a comment
There was a problem hiding this comment.
Ran the changes locally, seems to work. The config key should be added to resources/config-defaults.edn to avoid a warning on startup. Ready to merge once the checklist is updated and the new key is present in config-defaults.edn.
| ;; TODO list of resources? | ||
| ;; TODO use real name when addressing user? | ||
|
|
||
| (defn url [] (or (not-empty (:external-frontend-url env)) (:public-url env))) |
Collaborator
There was a problem hiding this comment.
Perhaps we could call this function
Suggested change
| (defn url [] (or (not-empty (:external-frontend-url env)) (:public-url env))) | |
| (defn base-url [] (or (not-empty (:external-frontend-url env)) (:public-url env))) |
to be a bit more specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for author
#3402
:external-frontend-urlconfiguration option. This is used to override the url in outbound emails for use cases where REMS is used in conjuction with an external frontend application.Remove items that aren't applicable, check items that are done.
Reviewability
Backwards compatibility
Documentation
Testing
Follow-up