fixing clap argument resolution panic

[alevar]

When attempting to compile from source - get panic on unresolved clap groups and arguments. Small fixes to address the issue.

[rob-p]

Thanks for the PR @alevar! I'm just rebasing on dev and will pull it in for a new release.

Can you share what cmd-line invocation triggered the panic for you?

Thanks!

[alevar]

I was running "oarfish --help" in debug which triggered the panic. The software was build from source (both direct clone and source files from the 0.9.0 release).

[rob-p]

Oh wow! Super surprised to not have caught that. Sometimes, I really wish CLAP had some less stringly-typed behavior.

[alevar]

It could be an issue on my end. Would like to know if you were able to replicate the error.

[rob-p]

Hi @alevar,

Indeed I could, but as you note, only in debug mode. I think I never caught it because it seems not to trigger in release mode. I guess Clap does more checks in debug mode than release mode. Nonetheless, I’ve merged the PR and cut a new release. Thanks for the fix!

—Rob