[docker] feat: add Ascend A3 Dockerfile and docs#659
Merged
FoolPlayer merged 1 commit intoByteDance-Seed:mainfrom Apr 20, 2026
Merged
[docker] feat: add Ascend A3 Dockerfile and docs#659FoolPlayer merged 1 commit intoByteDance-Seed:mainfrom
FoolPlayer merged 1 commit intoByteDance-Seed:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Ascend A3 hardware by adding a specialized Dockerfile and a comprehensive build and usage guide. It also refactors several training scripts to utilize a centralized FSDP mixed precision configuration. However, the review identified several critical issues in the implementation: the build_parallelize_model function is being called with an incorrect keyword argument, and several other functions are receiving a configuration object where a boolean value is expected, which will lead to logic errors or runtime failures. Additionally, the new Dockerfile contains redundant layers and references an undefined build variable.
FoolPlayer
reviewed
Apr 17, 2026
29ba4f6 to
445bae6
Compare
FoolPlayer
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR has added a Dockerfile for Ascend A3 and provided documentation for image construction. Additionally, some configuration code errors related to mixed precision training have been corrected.
Checklist Before Starting
[{modules}] {type}: {description}format (enforced by check_pr_title.yml)agent,ci,ckpt,config,data,dist,docker,docs,logging,misc,model,omni,optim,ops,parallel,perf,release,task,trainerfeat,fix,refactor,chore,test[BREAKING]— e.g.[BREAKING][parallel, model] feat: dynamic batchingTest
API and Usage Example
Design & Code Changes
Checklist Before Submitting
tasks/training scripts were moved or renamed: updateddocs/examples and verifiedpython3 scripts/ci/check_doc_task_paths.pypasses (also enforced by the Check doc task paths CI workflow)