Skip to content

[misc] fix: revert fsdp basic modules, fix it with VL models only#634

Merged
FoolPlayer merged 1 commit intoByteDance-Seed:mainfrom
heidongxianhua:up_main
Apr 13, 2026
Merged

[misc] fix: revert fsdp basic modules, fix it with VL models only#634
FoolPlayer merged 1 commit intoByteDance-Seed:mainfrom
heidongxianhua:up_main

Conversation

@heidongxianhua
Copy link
Copy Markdown
Contributor

What does this PR do?

Concise overview of the change. Reference related issues/PRs.

Checklist Before Starting

  • Search for relative PRs/issues and link here: ...
  • PR title follows [{modules}] {type}: {description} format (see check_pr_title.yml for the full list of allowed modules and types)
    • Breaking changes: prepend [BREAKING] — e.g. [BREAKING][parallel, model] feat: dynamic batching

Test

Validation results (training curves, eval metrics) for changes not covered by CI.

API and Usage Example

Show API changes and usage examples if applicable.

Design & Code Changes

High-level design description and specific change list.

Checklist Before Submitting

  • Read the Contribute Guide
  • Applied pre-commit checks
  • Added/updated documentation
  • If tasks/ training scripts were moved or renamed: updated docs/ examples and verified python3 scripts/ci/check_doc_task_paths.py passes (also enforced by the Check doc task paths CI workflow)
  • Added tests to CI workflow (or explained why not feasible)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added fix misc Every misc labels Apr 8, 2026
@Luosuu
Copy link
Copy Markdown
Collaborator

Luosuu commented Apr 10, 2026

@heidongxianhua please fix CI?

@heidongxianhua
Copy link
Copy Markdown
Contributor Author

@heidongxianhua please fix CI?

麻烦retry下吧, 机器问题

@FoolPlayer FoolPlayer merged commit 46018a2 into ByteDance-Seed:main Apr 13, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix misc Every misc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants