Open
Conversation
mingstat
reviewed
Apr 30, 2026
| checkmate::assert_numeric(height_range, len = 2, lower = 1, null.ok = TRUE) | ||
| checkmate::assert_string(title, min.chars = 1, null.ok = TRUE) | ||
| checkmate::assert_string(subtitle, min.chars = 1, null.ok = TRUE) | ||
| checkmate::assert_string(filter_var, null.ok = TRUE) |
Contributor
There was a problem hiding this comment.
Validation is needed to ensure that filter_var exists in the dataset.
Author
There was a problem hiding this comment.
I have now added a check for this in the spiderplot_server() function where the datasets are processed.
mingstat
reviewed
Apr 30, 2026
| title = "Interactive Spider Plot", | ||
| subtitle = "CDISC-PILOT-01" | ||
| subtitle = "CDISC-PILOT-01", | ||
| filter_var = "ARM" |
Contributor
There was a problem hiding this comment.
It would be helpful to also mention filter_values and filter_default_vals here.
Author
There was a problem hiding this comment.
Agreed, I have now added those two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical checks
Is the test version number correct (x.x.x-9000)?
DESCRIPTION file
NEWS.md
Does the build pass?
Documentation
Does it include the following sections?
Module introduction with features
Installation details
Explanation of function arguments
Data specifications and requirements
Different possible visualizations
Are the changes/new features included in NEWS.md?
(O) Explanation of input menus
(O) Short articles on building the app, compatibility with other modules, known bugs,...
QC Report
Does it include a QC Report with positive outcome?
Are the new features reflected accordingly in the specs?
API conventions