ci: introduce CI system based on that from rust-secp#6
Merged
apoelstra merged 5 commits intoBlockstreamResearch:masterfrom Jun 26, 2025
Merged
ci: introduce CI system based on that from rust-secp#6apoelstra merged 5 commits intoBlockstreamResearch:masterfrom
apoelstra merged 5 commits intoBlockstreamResearch:masterfrom
Conversation
Somehow this got dropped from BlockstreamResearch#1.
Removed benchmarks, asan etc, wasm stuff; removed lockfile logic; cleaned up some things with chatgpt; emptied the scripts in contrib/ but left enough of the framework in place that we should understand how to update them.
Contributor
Author
|
cc @canndrew this should be good to go |
apoelstra
force-pushed
the
2025-06_ci
branch
2 times, most recently
from
0eb9eb2 to
f76c63b
Compare
The linked-hash-map version in our lockfile appears to be using uninitialized memory in an unsound way, as evidenced by rustc 1.63.0 causing it to emit the error "Execution failed: attempted to leave type `linked_hash_map::Node<yaml::Yaml, yaml::Yaml>` uninitialized, which is invalid" in our CLI tests. Just update the dep.
canndrew
reviewed
Jun 26, 2025
tests/cli.rs
Outdated
| "", | ||
| ); | ||
| // FIXME we accept hybrid and uncompressed keys for blinders, which is probably wrong. But | ||
| // observa that thep |
Contributor
Author
There was a problem hiding this comment.
Lol, oops. Fixed.
Let Claude 4 write a couple of these. It did a pretty bad job. Was fairly expensive to round-trip through aider; it would make up addresses in the wrong format; I told it to try all the flags but it didn't try -v; it didn't use the short forms. So the vast majority of this was a manual commit. Took me several hours. Added a bunch of FIXMEs for things that look or feel wrong. We can revisit them in later PRs.
Contributor
|
ACK 3f12a65 |
Contributor
Author
|
Whew. Took me quite a while to get my local CI to like this. It's hard to set the Anyway I got it working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed benchmarks, asan etc, wasm stuff; removed lockfile logic; cleaned up some things with chatgpt; emptied the scripts in contrib/ but left enough of the framework in place that we should understand how to update them.
This is the same as #4 and #5 -- #4 did not run the CI, apparently because I was PR'ing from my fork instead of from the main repo, and #5 I closed by accident trying to convince
jjthat even though I had pushed to the main repo, I owned this commit and it was totally ok for me to force-push it around.Fixes #2