[#2106] Preserve KeysetAwarePage type for JPA Query Methods#2107
Draft
mj-p wants to merge 2 commits intoBlazebit:mainfrom
Draft
[#2106] Preserve KeysetAwarePage type for JPA Query Methods#2107mj-p wants to merge 2 commits intoBlazebit:mainfrom
mj-p wants to merge 2 commits intoBlazebit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes keyset page type loss during Spring Data result mapping for JPA query methods.
AbstractJpaQueryuses aResultProcessorthat maps slice/page results viaSlice#map(...).When the source is
KeysetAwarePageImpl, inheritedPageImpl#map(...)returns a plainPageImpl, which drops keyset-aware type information.This change overrides
map(...)inKeysetAwarePageImplso mapped results remainKeysetAwarePageImpl, preserving keyset metadata and pageable semantics.Related Issue
#2106
Motivation and Context
The runtime failure occurs in proxy/interceptor paths that expect
KeysetAwarePage, after Spring Data re-materializes mapped results asPageImpl.Observed exception:
java.lang.ClassCastException: org.springframework.data.domain.PageImpl cannot be cast to com.blazebit.persistence.spring.data.repository.KeysetAwarePageBy preserving the concrete keyset-aware page type in
map(...), the expected runtime contract remains intact and keyset pagination metadata is retained.