fix: propagate the verbose to the Prefill tqdm#1015
Open
PeterStaar-IBM wants to merge 1 commit intoBlaizzy:mainfrom
Open
fix: propagate the verbose to the Prefill tqdm#1015PeterStaar-IBM wants to merge 1 commit intoBlaizzy:mainfrom
PeterStaar-IBM wants to merge 1 commit intoBlaizzy:mainfrom
Conversation
PeterStaar-IBM
commented
Apr 12, 2026
PeterStaar-IBM
commented
- generate_step signature (line 397): Added verbose: bool = False parameter before **kwargs.
- Prefill tqdm (line 533): Added disable=not verbose to suppress the bar when verbose=False.
- stream_generate (line 604): Added verbose = kwargs.pop(verbose, False) to extract verbose from kwargs before it reaches generate_step.
- generate_step call in stream_generate (line 733): Added verbose=verbose to forward it explicitly.
- generate → stream_generate call (line 858): Added verbose=verbose so the top-level generate() function's verbose flag also controls the Prefill bar.
1. generate_step signature (line 397): Added verbose: bool = False parameter before **kwargs. 2. Prefill tqdm (line 533): Added disable=not verbose to suppress the bar when verbose=False. 3. stream_generate (line 604): Added verbose = kwargs.pop(verbose, False) to extract verbose from kwargs before it reaches generate_step. 4. generate_step call in stream_generate (line 733): Added verbose=verbose to forward it explicitly. 5. generate → stream_generate call (line 858): Added verbose=verbose so the top-level generate() function's verbose flag also controls the Prefill bar. Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Author
|
@Blaizzy Let me know if we can pull this in and release. We are a big fan of mlx-vlm in Docling (https://github.com/docling-project/docling), but we are currently seeing a lot of log pollution due to the Prefill tqdm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.