update to ro-crate models and connections to linked data terms#7
Merged
update to ro-crate models and connections to linked data terms#7
Conversation
AybukeKY
reviewed
Apr 28, 2025
AybukeKY
left a comment
AybukeKY
left a comment
There was a problem hiding this comment.
I know output.json is not specific to this PR but I don't see the associations there and I don't see any associations between the datasets (or the images) and their biosample and imaging acquisitions in the output.json (or the json produced by ingest command).
Contributor
Author
|
Associations shouldn't be there anyway, but the code has not yet been written to assign biosample etc to datasets. |
sherwoodf
force-pushed
the
update_ro_crate_models
branch
from
a960315 to
0f157d5
Compare
AybukeKY
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests will fail until rebased on: #6
ticket: https://app.clickup.com/t/8698uqur3