Thin dependencies significantly #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilfox
requested review from
anarchivist,
danschmidt5189,
davezuckerman and
jason-raitz
awilfox
force-pushed
the
awilfox/AP-470-dep-thinning
branch
from
d7cb92c to
71c13a7
Compare
awilfox
changed the title
Member
Author
|
I'm expecting some amount of changes needed. I will remove the '[WIP]' tag from the commit message when I make the next change. (I don't want to trigger the runners for a single commit message change.) |
* Remove lint dependencies from dev target, as linting cannot be done within the app. Too many dependency conflicts (anthropic causes pydoclint to crash, mypy typing bloats image size ~200 MB, etc). * Vendor the tiny bits of langchain_community we need to drop that. * Pull in lint deps for linting runs. Implements: AP-470
awilfox
force-pushed
the
awilfox/AP-470-dep-thinning
branch
from
71c13a7 to
6e4ea80
Compare
Member
Author
|
Fixed commit message. Will merge after CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove lint dependencies from dev target, as linting cannot be done within the app. Too many dependency conflicts (anthropic causes pydoclint to crash, mypy typing bloats image size ~200 MB, etc).
Vendor the tiny bits of langchain_community we need to drop that.
Pull in lint deps for linting runs.
Implements: AP-470
Tested running the pipeline and it ran fine. The LanceDB module was very easy to pull out of langchain_community; PyPDF not so much. The lint dependencies are pulled on-demand in GitHub Actions. It does not appear to cause any significant delay in runtime.