Skip to content

Draft: ADA-234: Ensure that the page, or at least one of its frames contains a level-one heading #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzhoubk merged 5 commits into from
Aug 4, 2025
Merged

Draft: ADA-234: Ensure that the page, or at least one of its frames contains a level-one heading #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0502ce
test
yzhoubk Jun 23, 2025
3cd39a7
add h1,h2
yzhoubk Jun 24, 2025
c75adf1
use taghelper for creating h1,h2
yzhoubk Jul 31, 2025
dde0dc0
Add containd_head existing case
yzhoubk Jul 31, 2025
c36cfec
remove test span, set h2 specifically for home page
yzhoubk Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,7 @@ PLATFORMS
aarch64-linux
arm64-darwin-22
x86_64-darwin-22
x86_64-darwin-24
x86_64-linux
x86_64-linux-musl

Expand Down
8 changes: 7 additions & 1 deletion app/views/layouts/blacklight/base.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@
<div class="ucb_container">
<%= render partial: 'shared/header_navbar' %>
<main id="main-container" class="<%= container_classes %>" role="main" aria-label="<%= t('blacklight.main.aria.main_container') %>">
<%= content_for(:container_header) %>
<%= content_for(:container_header) || content_tag(:div, class: "sr-only visually-hidden") do
if render_page_title == "UC Berkeley GeoData"
content_tag(:h1, render_page_title) + content_tag(:h2, render_page_title + " Categories")
else
content_tag(:h1, render_page_title)
end
Comment on lines +50 to +54
Copy link
Copy Markdown
Member

@awilfox awilfox Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been slightly more efficient to do

                content_tag(:h1, render_page_title)
                content_tag(:h2, render_page_title + " Categories") if render_page_title == "UC Berkeley GeoData"

Copy link
Copy Markdown
Contributor Author

@yzhoubk yzhoubk Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this won't work.

end %>
<%= render partial: 'shared/flash_msg', layout: 'shared/flash_messages' %>

<div class="row">
Expand Down