Modify build_unicorn_support.sh to not require root for most build steps#8
Modify build_unicorn_support.sh to not require root for most build steps#8rbdixon wants to merge 1 commit intoBattelle:masterfrom
Conversation
| echo "[*] Performing basic sanity checks..." | ||
|
|
||
| if [ "$(id -u)" != "0" ]; then | ||
| if [ "$(id -u)" = "0" ]; then |
There was a problem hiding this comment.
Should we specifically preclude users from installing as root here? Would it be better to just remove this check completely?
njv299
left a comment
njv299
left a comment
There was a problem hiding this comment.
Awesome changes! I actually think we can remove the 'sudo' check altogether now, but I want to get your feedback on it.
Thanks for the help!
…eps. Now uses a git submodule, rather than wget, to download and verify unicorn integrity. Root is not required for building. sudo is used to install unicorn binaries.
|
Updated to remove the sudo check as discussed. |
njv299
left a comment
njv299
left a comment
There was a problem hiding this comment.
Testing this works great up until the call to make and install the Python bindings (via 'python setup.py install'). If the build script is run without sudo it fails at this point (on my test system, a stock ubuntu 16.04 box). I think this could be remedied in a couple ways, including adding 'sudo' when making the bindings or re-thinking the whole bindings build process (pip? virtualenv? This seems unnecessary to me).
For now my vote would be to just add 'sudo' to the python bindings install, then adjust the unicorn_mode readme to say that the install script should be run with sudo.
I'm definitely open to suggestions, though!
|
I'll take another crack at this next week. |
2 participants
Quick swipe to try to help out with #4.
Now uses a git submodule, rather than wget, to download and verify unicorn
integrity. Root is not required for building. sudo is used to install unicorn
binaries.
Thanks for the talk at Shmoocon.