feat(ftp): add SSH key authentication for SFTP#968
Merged
heloise-gllm merged 7 commits intodevelopfrom Feb 23, 2026
Merged
Conversation
Add support for SSH key authentication in addition to password authentication for SFTP image hosting. ## Changes ### Dependencies - Upgrade ssh2-sftp-client from 5.1.2 to 7.2.3 (fixed version) - Required for rsa-sha2-256/512 support (OpenSSH 8.8+) ### Backend - group.schema.js: Add ftpAuthType (password/ssh_key) and ftpSshKey fields - ftp-client.service.js: Support privateKey in connection settings - mailing.service.js: Pass auth type and SSH key to FTP client - group.controller.js: - Validate SSH key format (PEM/OpenSSH) - Mask ftpPassword and ftpSshKey in API responses - Handle credential updates (preserve masked, delete with __DELETE__) - Add testFtpConnection endpoint - group.routes.js: Add POST /:groupId/test-ftp-connection route ### Frontend - form.vue: Auth method selector, SSH key textarea, test connection button - api-routes.js: Add groupTestFtpConnection route - Translations FR/EN for new fields ## Supported key types (Node 14) - RSA 2048+ ✓ - ECDSA ✓ - Ed25519 ✗ (requires Node 16+) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Fix undefined groupId error for admin users without a group - Fix maskFtpCredentials using toJSON() to include Mongoose virtuals (id) - Pass ftpAuthType and ftpSshKey through ftpServerParams to FTP client 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add 4 clear sections: General Info, Image Hosting, Authentication, Permissions - Group FTP fields logically: connection, authentication, paths, display - Add visual encapsulation for FTP and CDN subsections - Move permissions checkbox to its own section (was buried in SAML) - Add section titles with FR/EN translations - Fix typo: "Compagny" → "Company" in English locale 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
## Code Quality Improvements - Extract FTP logic from group.controller.js to group-ftp.service.js - Extract FTP form fields from form.vue to ftp-settings.vue component - Add ERROR_CODES for FTP/SSH errors (standardized error handling) - Fix console.error to use development-only logging in user.js store ## Tests - Add 29 unit tests for group-ftp.service.js (100% coverage) - Tests cover: validateSshKeyFormat, maskFtpCredentials, processCredentialsForUpdate, mapFtpError ## File Size Reduction - group.controller.js: 587 → 463 lines (-124) - form.vue: 695 → 477 lines (-218) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…gle management and var deletion
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
JeanneGrenet
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Features
Code Quality
group-ftp.service.jsfrom controller (209 lines)ftp-settings.vuecomponent (285 lines)UI Improvements
Test Plan