Fix #20 Get pixel storei on textures

documentation/changeLogs.md

@@ -5,7 +5,8 @@
 Please, find below the per release summary of the contribution added to the project per version. Each of the listed versions is having its corresponding tag in the repo.
 
 ## v0.9.33
-* Add [Offscreen canvas support](https://github.com/BabylonJS/Spector.js/pull/345)
+* Add [Texture Storei Information](https://github.com/BabylonJS/Spector.js/issues/80)
+* Add [MCP Support](https://github.com/BabylonJS/Spector.js/pull/345)
 * Add [Offscreen canvas support](https://github.com/BabylonJS/Spector.js/pull/343)
 * Add [Typescript typings](https://github.com/BabylonJS/Spector.js/pull/339)
 * Migrate [MVX to React](https://github.com/BabylonJS/Spector.js/pull/338)

src/backend/recorders/baseRecorder.ts

@@ -4,6 +4,7 @@ import { WebGlConstants, WebGlConstantsByValue } from "../types/webglConstants";
 import { FunctionCallbacks, IFunctionInformation } from "../types/functionInformation";
 import { ICapture } from "../../shared/capture/capture";
 import { WebGlObjects } from "../webGlObjects/baseWebGlObject";
+import { IPixelStoreState } from "./texture2DRecorder";
 
 export interface IRecorder {
     registerCallbacks(onFunctionCallbacks: FunctionCallbacks): void;
@@ -220,4 +221,25 @@ export abstract class BaseRecorder<T extends WebGLObject> implements IRecorder {
         const bytesPerElements = BaseRecorder.byteSizePerInternalFormat[internalFormat];
         return bytesPerElements || 4;
     }
+
+    protected readPixelStoreState(): IPixelStoreState {
+        const gl = this.options.context;
+        const state: IPixelStoreState = {
+            UNPACK_FLIP_Y_WEBGL: gl.getParameter(WebGlConstants.UNPACK_FLIP_Y_WEBGL.value),
+            UNPACK_PREMULTIPLY_ALPHA_WEBGL: gl.getParameter(WebGlConstants.UNPACK_PREMULTIPLY_ALPHA_WEBGL.value),
+            UNPACK_COLORSPACE_CONVERSION_WEBGL: gl.getParameter(WebGlConstants.UNPACK_COLORSPACE_CONVERSION_WEBGL.value),
+            UNPACK_ALIGNMENT: gl.getParameter(WebGlConstants.UNPACK_ALIGNMENT.value),
+        };
+
+        // Add WebGL2-only parameters if available
+        if (gl instanceof WebGL2RenderingContext) {
+            state.UNPACK_ROW_LENGTH = gl.getParameter(WebGlConstants.UNPACK_ROW_LENGTH.value);
+            state.UNPACK_IMAGE_HEIGHT = gl.getParameter(WebGlConstants.UNPACK_IMAGE_HEIGHT.value);
+            state.UNPACK_SKIP_PIXELS = gl.getParameter(WebGlConstants.UNPACK_SKIP_PIXELS.value);
+            state.UNPACK_SKIP_ROWS = gl.getParameter(WebGlConstants.UNPACK_SKIP_ROWS.value);
+            state.UNPACK_SKIP_IMAGES = gl.getParameter(WebGlConstants.UNPACK_SKIP_IMAGES.value);
+        }
+
+        return state;
+    }
 }

src/backend/recorders/texture2DRecorder.ts

@@ -4,6 +4,19 @@ import { WebGlConstants } from "../types/webglConstants";
 
 import { IFunctionInformation } from "../types/functionInformation";
 
+export interface IPixelStoreState {
+    UNPACK_FLIP_Y_WEBGL?: boolean;
+    UNPACK_PREMULTIPLY_ALPHA_WEBGL?: boolean;
+    UNPACK_COLORSPACE_CONVERSION_WEBGL?: number;
+    UNPACK_ALIGNMENT?: number;
+    /** WebGL2 only */
+    UNPACK_ROW_LENGTH?: number;
+    UNPACK_IMAGE_HEIGHT?: number;
+    UNPACK_SKIP_PIXELS?: number;
+    UNPACK_SKIP_ROWS?: number;
+    UNPACK_SKIP_IMAGES?: number;
+}
+
 export interface ITextureRecorderData {
     target: string;
     internalFormat: number;
@@ -14,6 +27,7 @@ export interface ITextureRecorderData {
     type?: number;
     depth?: number;
     isCompressed: boolean;
+    pixelStoreState?: IPixelStoreState;
 }
 
 export class Texture2DRecorder extends BaseRecorder<WebGLTexture> {
@@ -67,6 +81,9 @@ export class Texture2DRecorder extends BaseRecorder<WebGLTexture> {
             return 0;
         }
 
+        // Snapshot pixelStorei state at upload time
+        customData.pixelStoreState = this.readPixelStoreState();
+
         const previousLength = (instance as any).__SPECTOR_Object_CustomData ? (instance as any).__SPECTOR_Object_CustomData.length : 0;
         if (customData.isCompressed) {
             // Compressed textures are worth the size of their data.

src/backend/recorders/texture3DRecorder.ts

@@ -53,6 +53,9 @@ export class Texture3DRecorder extends BaseRecorder<WebGLTexture> {
             return 0;
         }
 
+        // Snapshot pixelStorei state at upload time
+        customData.pixelStoreState = this.readPixelStoreState();
+
         const previousLength = (instance as any).__SPECTOR_Object_CustomData ? (instance as any).__SPECTOR_Object_CustomData.length : 0;
         if (customData.isCompressed) {
             // Compressed textures are worth the size of their data.