-
Notifications
You must be signed in to change notification settings - Fork 205
Material Management: Import .3dm/matprop & Export matprop #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aidanthomas26
wants to merge
92
commits into
BRL-CAD:main
Choose a base branch
from
graceung:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read material name and set as shader name in 3dm-g
create_material and assign
read all materials and assign after
… multi-line content - improve the parsing to handle it.
Want to test out the ssdeep fuzzy hashing algorithm to group similar .g files. Of the available implementations, SsdeepNET has an MIT license but was implemented in C#. Tried out Github Copilot to see if it could produce a C++ version of the SsdeepNET code. A basic test with the gdiff regression test examples seems to produce reasonable results, so go ahead and stash the header. Next up will be to figure out a good way to analyze a lot of files to identify and report groupings.
With bext, we have the upstream project from which these algorithm implementations were orignially derived. Simplify our own code by directly using the upstream and removing the translations - upstream is actively maintained, so in addition to code simplification we will benefit from any bug fixes and improvements they make.
…son we can't still print help.
Global registry objects (using STL containers) in libged and libdm were defined as static variables at file scope. This risks "static initialization order fiasco" - static constructors from other translation units (TUs) may access the registries before they are initialized, causing crashes or undefined behavior, especially in static builds with plugins. The solution is to convert global registry objects to function-local static "Meyers singletons". All registry accesses now use singleton getter functions, ensuring construction is ordered and thread-safe by C++11 guarantees. With this approach function-local statics are initialized on first use, guaranteeing that any plugin constructor or TU macro accessing the registry always gets a fully constructed object, regardless of cross-TU initialization order. This makes static and dynamic plugin registration robust across all platforms and build/link scenarios.
read through all materials not just assigned ones
supported legacy mats
remove thirdgen not documented
…erwrite the data of specific objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple import and export material information with usage commands available.