Skip to content

Comments

Backgroundjob bugfix#807

Open
jfmaes wants to merge 3 commits intoBC-SECURITY:mainfrom
jfmaes:backgroundjob-bugfix
Open

Backgroundjob bugfix#807
jfmaes wants to merge 3 commits intoBC-SECURITY:mainfrom
jfmaes:backgroundjob-bugfix

Conversation

@jfmaes
Copy link

@jfmaes jfmaes commented Feb 8, 2026

i changed the default timer to 0 for interactive check in, figured thats the most sensible default. operators can change this of course.

had to also modify empire agents for background tasksings (see starkiller PR)

@vinnybod
Copy link

Hey @jfmaes, thanks for the contribution!

I reviewed the PR and had a few notes:

  • Some local dev artifacts snuck in — the .gitignore got replaced, there's a hardcoded Starkiller
    path in data_manager.py, and a few config changes (auto_update, .python-version, Starkiller
    submodule) that look unintentional.
  • The Background param override in module_service.py was doing string parsing on the raw params,
    but since the YAML options declare type: bool, the value is already coerced to a Python bool by the
    time it reaches execute_module. The string .lower() call would actually crash with an
    AttributeError. Swapped it to read from cleaned_options instead.

I had Claude Code put together a fixup commit that addresses all of the above and adds a test +
docs for the Background option. I'll open a PR into your branch — feel free to accept it or implement it on your own.

jfmaes#1

Thanks again for the work on this!

@jfmaes
Copy link
Author

jfmaes commented Feb 15, 2026

Yeah my github skills are pretty terrible 😂. Hope this makes it in the project though! As for the dev starkiller, I think thats actually a cool feature. I couldnt find docs on how to force empire to use a local starkiller. Seemed to always pull from git and use that. So I hackedy dackedie'd a patch. Anyway, hope its useful!

@vinnybod
Copy link

vinnybod commented Feb 15, 2026

I couldnt find docs on how to force empire to use a local starkiller.

It might not be well documented, but the answer is you can just run starkiller's dev server which runs on port 5173. I could see a nice feature where the Starkiller config can accept a file path instead of a remote repo though. We have that for the empire compiler iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants