-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Azure][Migrate][OffAzure][v2025-12-12-preview][NEW] #39122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Azure][Migrate][OffAzure][v2025-12-12-preview][NEW] #39122
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
@microsoft-github-policy-service agree company="Microsoft" |
v5/v6. Here and other places of this PR. Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4045 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
example shows request body as empty. Is this request body needed then ? If its needed - schematize the body and update examples. Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4068 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
it should be verb+action format. May be say, importMachinesToMasterSite or something similar that suits better. Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4036 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
nit: in descending order Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4098 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
may be , importJobs? Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4092 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
ARM is an internal wording. Please avoid using that. Here and other places of this PR. Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4073 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
In general, most teams use '01' as the date part of the api-version. I see your team's new api-versions also use '01' Can you stick to that for consistency? Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:5 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False) |
This PR introduces support for the new optional property migrateProjectId in the MasterSite model, along with other apis/
Key updates include with new API version for OffAzure 2025-12-12-preview:
Added optional field migrateProjectId to MasterSite.
Added MasterSite import job URI to include and handle this property.
Extended MasterSite job/getAllJobs retrieval and tracking APIs to expose and process the new property.