Skip to content

Conversation

@YashGokhru
Copy link

This PR introduces support for the new optional property migrateProjectId in the MasterSite model, along with other apis/
Key updates include with new API version for OffAzure 2025-12-12-preview:

Added optional field migrateProjectId to MasterSite.

Added MasterSite import job URI to include and handle this property.

Extended MasterSite job/getAllJobs retrieval and tracking APIs to expose and process the new property.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Migrate-Microsoft.OffAzure
JavaScript @azure/arm-migrationdiscovery
JavaScript @azure/arm-migrate
Python azure-mgmt-migrationdiscovery
Python azure-mgmt-migrate

@YashGokhru
Copy link
Author

@YashGokhru please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@ramoka178
Copy link
Contributor

        "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter"

v5/v6. Here and other places of this PR.


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4045 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

        }

example shows request body as empty. Is this request body needed then ?

If its needed - schematize the body and update examples.
If its not needed - remove from here.


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4068 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/masterSites/{siteName}/import": {

it should be verb+action format.

May be say, importMachinesToMasterSite or something similar that suits better.


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4036 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "description": "Gets all import jobs in a master site. Jobs are returned sorted descending by start time.",

nit: in descending order


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4098 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "startTime": {

startTimeInUTC ?


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:17396 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "endTime": {

endTimeInUTC ?


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:17401 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "status": {

can this be from a list of enums ?


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:17391 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "blobCreationTimeStamp": {

blobCreationTimeStampInUTC?


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:17419 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/masterSites/{siteName}/jobs": {

may be , importJobs?


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4092 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

        "description": "ARM operation completed successfully.",

ARM is an internal wording. Please avoid using that.
May be say, Azure operation... ?

Here and other places of this PR.


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4073 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

        "description": "Job Arm Name.",

ARM is an internal wording. Please avoid using that.


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:4170 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178
Copy link
Contributor

"version": "2025-12-12-preview",

In general, most teams use '01' as the date part of the api-version. I see your team's new api-versions also use '01'

Can you stick to that for consistency?
either 2025-12-01-preview or 2026-01-01-preview


Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2025-12-12-preview/migrate.json:5 in 2c7f534. [](commit_id = 2c7f534, deletion_comment = False)

@ramoka178 ramoka178 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMChangesRequested ARMReview brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants