Add --enable-os-disk-full-caching for create/nodepool add#9841
Add --enable-os-disk-full-caching for create/nodepool add#9841weiliu2dev wants to merge 1 commit intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @weiliu2dev, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @weiliu2dev Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
Adds support for enabling “full-cache ephemeral OS disk” on AKS nodepools (create + nodepool add) in the aks-preview extension.
Changes:
- Adds
--enable-os-disk-full-caching(preview) toaz aks createandaz aks nodepool add. - Wires the new flag through the agentpool decorator context and agentpool profile construction.
- Adds unit tests and help/changelog documentation for the new flag.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds unit tests for new context getter and decorator setup behavior. |
| src/aks-preview/azext_aks_preview/custom.py | Adds enable_os_disk_full_caching param to command function signatures (but also drops control_plane_scaling_size). |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Implements getter + agentpool field setup and plugs it into profile construction. |
| src/aks-preview/azext_aks_preview/_params.py | Adds CLI arguments for the new flag (but removes control_plane_scaling_size argument). |
| src/aks-preview/azext_aks_preview/_help.py | Documents the new flag (but removes --control-plane-scaling-size help/examples). |
| src/aks-preview/HISTORY.rst | Adds changelog entry for new flag; still mentions --control-plane-scaling-size. |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/_params.py:1274
- The
aks createargument definition forcontrol_plane_scaling_sizewas removed here, butmanaged_cluster_decorator.pystill readsraw_param['control_plane_scaling_size']and there are existing tests and HISTORY entries for this flag. This looks like an accidental regression that will make--control-plane-scaling-size/--cp-scaling-sizeunavailable. Please restore thec.argument(...)block (or, if intentionally removed, also clean up the decorator/tests/HISTORY accordingly).
c.argument(
"enable_gateway_api",
action="store_true",
help="Enable managed installation of Gateway API CRDs from the standard release channel."
)
c.argument(
"enable_app_routing_istio",
options_list=["--enable-app-routing-istio", "--enable-ari"],
action="store_true",
is_preview=True,
help="Enable Gateway API based ingress on App Routing via Istio"
)
c.argument("enable_hosted_system", action="store_true", is_preview=True)
c.argument(
"enable_continuous_control_plane_and_addon_monitor",
action="store_true",
is_preview=True,
help="Enable continuous control plane and addon monitor for the cluster.",
)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
highly recommend adding a scenario test to cover the change |
4256ea9 to
d97c877
Compare
Added in latest push (531dffb):
|
d97c877 to
531dffb
Compare
531dffb to
f97ce1f
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.