Skip to content

{AKS} az aks create/update: Update container network logs error message to mention portal enablement of ACNS #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlotaarvela wants to merge 1 commit into from
Closed

{AKS} az aks create/update: Update container network logs error message to mention portal enablement of ACNS #9837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

20.0.0b6
+++++++
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section underline for the new "20.0.0b6" heading is shorter than the heading text (7 '+' vs 8 chars). In reStructuredText, section adornment lines should be at least as long as the title to avoid rendering/parsing warnings; please adjust the underline length accordingly.

Suggested change
+++++++
++++++++

Copilot uses AI. Check for mistakes.
* `az aks create/update`: Improve error message for container network logs validation when ACNS is not enabled to provide clearer guidance.

20.0.0b5
+++++++
* `az aks update`: Fix acceleration mode getting wiped out when modifying unrelated parameters in an ACNS enabled cluster.
Expand Down
6 changes: 4 additions & 2 deletions src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,8 +1083,10 @@ def get_container_network_logs(self, mc: ManagedCluster) -> Union[bool, None]:
monitoring_enabled = monitoring_being_enabled or monitoring_already_enabled
if not acns_enabled or not monitoring_enabled:
raise InvalidArgumentValueError(
"Container network logs requires '--enable-acns', advanced networking "
"to be enabled, and the monitoring addon to be enabled."
"Container network logs require Advanced Container Networking Services to be enabled. "
"Activate this service through the portal or use the CLI with --enable-acns flag. "
"Additionally, the monitoring addon must be enabled and the cilium network dataplane "
"is required."
Comment on lines 1084 to +1089
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raised error message mentions requirements (ACNS enablement via portal/--enable-acns, monitoring addon, and cilium dataplane), but the validation here only checks ACNS + monitoring (no cilium check) and it triggers for either missing prerequisite. This can mislead users (e.g., ACNS already enabled but monitoring missing). Consider tailoring the message based on which condition failed and either (a) add an explicit cilium dataplane validation if it’s truly required, or (b) drop/soften the cilium statement to match what is validated here.

Copilot uses AI. Check for mistakes.
)
enable_cnl = bool(enable_cnl) if enable_cnl is not None else False
disable_cnl = bool(disable_cnl) if disable_cnl is not None else False
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import find_packages, setup

VERSION = "20.0.0b5"
VERSION = "20.0.0b6"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down
Loading