[connectedk8s] Update extension CLI to v1.11.1#9817
Conversation
* forcedelete * format * add code owner * mypy
… '2025-08-01-preview' (#17)
…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]>
* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> * remove breaking change announcement for removed flags --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]>
* adjusting arm64 support * editing * adding * Revert k8s-extension changes from this repo * changes * changing order * fix ruff: ternary for arch, remove unused artifactTag * fix ruff format * fix mypy type: ignore comments in _utils.py * raise CLIInternalError instead of silent fallbacks in _resolve_helm_pull_target * use requests instead of oras internals for manifest resolution * add MCR anonymous bearer token auth for manifest resolution * fix MCR resolution: add Accept header, fetch child manifests for annotations
the tests passed, the typecheck and extension index failures are not relevant to this PR * switch * fixswitch * addhelm4test * specificexception
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR releases the connectedk8s Azure CLI extension version 1.12.0, updating Helm/client tooling behavior and cloud-specific endpoint handling to improve compatibility across architectures and Helm versions.
Changes:
- Added ARM64-aware Helm client installation logic (including MCR pull target resolution).
- Updated Helm behavior for Helm 4 compatibility (
helm listflag handling) and added AGC-specific Helm overrides. - Bumped extension/package versions and refreshed related constants; removed deprecated RBAC parameters and hardcoded ARM base URL.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/k8s-extension/azext_k8s_extension/utils.py | Updates get_mcr_path signature/logic to accept an AAD endpoint string and handle sovereign cloud differences. |
| src/k8s-extension/azext_k8s_extension/custom.py | Updates Helm install flow to call the new get_mcr_path signature. |
| src/connectedk8s/setup.py | Bumps extension version to 1.12.0. |
| src/connectedk8s/azext_connectedk8s/tests/unittests/test_utils_.py | Adds unit coverage for get_mcr_path behavior across endpoint shapes. |
| src/connectedk8s/azext_connectedk8s/custom.py | Adds ARM64 support for Helm install and introduces OCI manifest-based pull target resolution. |
| src/connectedk8s/azext_connectedk8s/clientproxyhelper/_binaryutils.py | Updates MCR URL resolution to use the new get_mcr_path signature. |
| src/connectedk8s/azext_connectedk8s/_utils.py | Updates MCR URL resolution, Helm 4 compatibility logic, and adds AGC override helper(s). |
| src/connectedk8s/azext_connectedk8s/_precheckutils.py | Updates MCR URL resolution to use the new get_mcr_path signature. |
| src/connectedk8s/azext_connectedk8s/_params.py | Removes deprecated --app-id and --app-secret parameters from enable-features. |
| src/connectedk8s/azext_connectedk8s/_constants.py | Updates Helm/precheck/proxy-related version constants. |
| src/connectedk8s/azext_connectedk8s/_client_factory.py | Removes hardcoded public ARM base URL to respect cloud endpoints. |
| src/connectedk8s/azext_connectedk8s/_breaking_change.py | Removes deprecated breaking-change registration entries for removed RBAC args. |
| src/connectedk8s/HISTORY.rst | Adds 1.12.0 release notes and inserts intermediate release entries. |
| DNS_Check_Result_String = "DNS Result:" | ||
| AZ_CLI_ADAL_TO_MSAL_MIGRATE_VERSION = "2.30.0" | ||
| CLIENT_PROXY_VERSION = "1.3.029301" | ||
| CLIENT_PROXY_VERSION = "1.3.033581" |
There was a problem hiding this comment.
CLIENT_PROXY_VERSION is set to 1.3.033581 here, but the PR description and HISTORY.rst 1.12.0 entry state 1.3.033281. Please reconcile these so the code, changelog, and release notes all reference the same proxy version (either update this constant or fix the documented version).
| * Handle removal of '--all' flag in Helm 4 to ensure compatibility. | ||
| * Added Helm overrides support for Application Gateway for Containers (AGC). | ||
| * Updated CSP version. | ||
| * Updated CLIENT_PROXY_VERSION to 1.3.033281. |
There was a problem hiding this comment.
The 1.12.0 changelog entry says CLIENT_PROXY_VERSION was updated to 1.3.033281, but src/connectedk8s/azext_connectedk8s/_constants.py sets CLIENT_PROXY_VERSION to 1.3.033581. Please update this entry (or the constant) so the documented version matches what will actually ship.
| * Updated CLIENT_PROXY_VERSION to 1.3.033281. | |
| * Updated CLIENT_PROXY_VERSION to 1.3.033581. |
Description
Release of the
connectedk8sCLI extension, bumping version to1.11.1.Changes
--allflag in Helm 4 to ensure compatibility.References
AzureArcForKubernetes/connectedk8s:release-v1.12.0