Conversation
common/src/main/java/io/github/axolotlclient/modules/hypixel/HypixelAbstractionLayer.java
Outdated
Show resolved
Hide resolved
moehreag
left a comment
There was a problem hiding this comment.
Generally a lot of good things, however there's a few issues as well.
If possible please also don't change the import order
1.21.4/src/main/java/io/github/axolotlclient/api/chat/ChannelInvitesScreen.java
Outdated
Show resolved
Hide resolved
1.21.4/src/main/java/io/github/axolotlclient/mixin/PlayerListHudMixin.java
Outdated
Show resolved
Hide resolved
1.21.4/src/main/java/io/github/axolotlclient/modules/screenshotUtils/ImageScreen.java
Outdated
Show resolved
Hide resolved
1.21/src/main/java/io/github/axolotlclient/mixin/PlayerListHudMixin.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/axolotlclient/modules/hypixel/HypixelAbstractionLayer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/axolotlclient/modules/hypixel/HypixelAbstractionLayer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/axolotlclient/modules/hypixel/HypixelAbstractionLayer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/axolotlclient/modules/hypixel/levelhead/LevelHeadMode.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/axolotlclient/util/CachedAPI.java
Outdated
Show resolved
Hide resolved
1.8.9/src/main/java/io/github/axolotlclient/mixin/commands/LocalClientPlayerEntityMixin.java
Outdated
Show resolved
Hide resolved
1.8.9/src/main/java/io/github/axolotlclient/commands/ClientCommands.java
Outdated
Show resolved
Hide resolved
1.8.9/src/main/java/io/github/axolotlclient/commands/OfflinePlayerArgument.java
Outdated
Show resolved
Hide resolved
1.8.9/src/main/java/io/github/axolotlclient/commands/ClientCommands.java
Show resolved
Hide resolved
1.8.9/src/main/java/io/github/axolotlclient/mixin/commands/ChatScreenMixin.java
Outdated
Show resolved
Hide resolved
- correct winstreak property
Sorry, IDE configuration issue. Is there a standard import order specification? |
We have it set to Ideally this would be configured in the .editorconfig or another project-specific formatting file but since we don't know how to do that that's a bit difficult |
- use gson 2.8.0 in the common module since that's the oldest one anyone's going to use. Unfortunately it still doesn't support record deserialization. - move more code to asynchronous methods
That's IntelliJ's default. Also I'm pretty sure that cannot be configured with .editorconfig unfortunately. |
Spotless can enforce import order (as well as license checks), might be worth setting that up but gradle is annoying. |
# Conflicts: # 1.8.9/src/main/resources/axolotlclient.mixins.json
# Conflicts: # common/src/main/resources/assets/axolotlclient/lang/en_us.json
|
Thanks! |
Implement the
/playerstatscommand.LevelHead-> modulecommonsince it doesn't depend on MC.TODO:
HypixelAbstractionLayerto two parts: one to handle API and the other to handle game/transient stateNon goals (for this PR):