Skip to content
This repository was archived by the owner on Nov 28, 2025. It is now read-only.

Playerstats command#139

Merged
moehreag merged 31 commits intoAxolotlClient:devfrom
Floweynt:flowey/stats-command
Mar 6, 2025
Merged

Playerstats command#139
moehreag merged 31 commits intoAxolotlClient:devfrom
Floweynt:flowey/stats-command

Conversation

@Floweynt
Copy link
Copy Markdown
Contributor

@Floweynt Floweynt commented Feb 25, 2025

Implement the /playerstats command.

  • make API wrappers async & thread-safe
  • implement playerstats command for 1.8.9
  • bundle brigadier client-side (on 1.8.9) to hopefully enable better abstraction cross-version
  • move class LevelHead -> module common since it doesn't depend on MC.

TODO:

  • split HypixelAbstractionLayer to two parts: one to handle API and the other to handle game/transient state
  • configurable cache size
  • port to other versions
  • clean up rate-limit logic
  • implement for other games
  • add pretty colors

Non goals (for this PR):

  • Overlay

Copy link
Copy Markdown
Member

@moehreag moehreag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a lot of good things, however there's a few issues as well.
If possible please also don't change the import order

@Floweynt
Copy link
Copy Markdown
Contributor Author

If possible please also don't change the import order

Sorry, IDE configuration issue. Is there a standard import order specification?

@moehreag
Copy link
Copy Markdown
Member

If possible please also don't change the import order

Sorry, IDE configuration issue. Is there a standard import order specification?

We have it set to
import javax.* (with subpackages)
import java.* (with subpackages)
blank
import all other imports
blank
import static all other imports

Ideally this would be configured in the .editorconfig or another project-specific formatting file but since we don't know how to do that that's a bit difficult

@Astralchroma
Copy link
Copy Markdown
Member

If possible please also don't change the import order

Sorry, IDE configuration issue. Is there a standard import order specification?

We have it set to import javax.* (with subpackages) import java.* (with subpackages) blank import all other imports blank import static all other imports

Ideally this would be configured in the .editorconfig or another project-specific formatting file but since we don't know how to do that that's a bit difficult

That's IntelliJ's default.

Also I'm pretty sure that cannot be configured with .editorconfig unfortunately.

@Floweynt
Copy link
Copy Markdown
Contributor Author

Floweynt commented Mar 4, 2025

If possible please also don't change the import order

Sorry, IDE configuration issue. Is there a standard import order specification?

We have it set to import javax.* (with subpackages) import java.* (with subpackages) blank import all other imports blank import static all other imports
Ideally this would be configured in the .editorconfig or another project-specific formatting file but since we don't know how to do that that's a bit difficult

That's IntelliJ's default.

Also I'm pretty sure that cannot be configured with .editorconfig unfortunately.

Spotless can enforce import order (as well as license checks), might be worth setting that up but gradle is annoying.

@Floweynt Floweynt marked this pull request as ready for review March 5, 2025 00:28
moehreag added 7 commits March 5, 2025 10:58
# Conflicts:
#	1.8.9/src/main/resources/axolotlclient.mixins.json
# Conflicts:
#	common/src/main/resources/assets/axolotlclient/lang/en_us.json
@moehreag moehreag merged commit f73646e into AxolotlClient:dev Mar 6, 2025
1 check passed
@moehreag
Copy link
Copy Markdown
Member

moehreag commented Mar 6, 2025

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants