Conversation
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
14d565f to
88d8b3f
Compare
|
I've amended the PR, |
|
You can test this PR using the following package version. |
88d8b3f to
c640bbc
Compare
|
You can test this PR using the following package version. |
There was a problem hiding this comment.
Pull request overview
Adds a dedicated PopupOverlayLayer positioned in front of OverlayLayer so Avalonia popups are hosted separately, leaving OverlayLayer available for user-defined overlays.
Changes:
- Introduce
PopupOverlayLayerand register it inVisualLayerManagerwith a higher ZIndex thanOverlayLayer. - Update popup hosting (
OverlayPopupHost) and related docs/tests to usePopupOverlayLayerinstead ofOverlayLayer. - Expose
OverlayLayerpublicly to enable user code to add overlay content.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Avalonia.Controls.UnitTests/ToolTipTests.cs | Updates overlay measurement hook to target PopupOverlayLayer. |
| src/Avalonia.Controls/Primitives/VisualLayerManager.cs | Adds PopupOverlayLayer and updates layer ZIndex ordering. |
| src/Avalonia.Controls/Primitives/TextSelectorLayer.cs | Refactors layer lookup logic; minor cleanup. |
| src/Avalonia.Controls/Primitives/PopupOverlayLayer.cs | New layer implementation for hosting popups above OverlayLayer. |
| src/Avalonia.Controls/Primitives/OverlayPopupHost.cs | Switches popup host creation/hosting to PopupOverlayLayer. |
| src/Avalonia.Controls/Primitives/OverlayLayer.cs | Makes OverlayLayer public and refactors lookup/measure logic. |
| src/Avalonia.Controls/Primitives/IPopupHost.cs | Updates XML docs to reference PopupOverlayLayer. |
| src/Avalonia.Controls/Primitives/AdornerLayer.cs | Makes AdornerLayer constructor public. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You can test this PR using the following package version. |
What does the pull request do?
This PR adds a
PopupOverlayLayerthat's in front ofOverlayLayer. Avalonia popups are now inPopupOverlayLayerand users are free to add controls to theOverlayLayer.