Skip to content

Conversation

@bautismal
Copy link

Fix bug for issue #2523

Copy link
Member

@jfarcand jfarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bautismal This is a great start. I would check if the bb.array() is large enough (using the limit), and fall back to your solution if not. What do you think?

@bautismal
Copy link
Author

@jfarcand, Not sure what change you are suggesting?
I think the following code is a nonsense - copying the array to itself ?
Either directly return bb.array(), or create a new byte array and copy the contents of bb to it, or am I missing something?

byte[] b = bb.array();
bb.get(b);

@jfarcand jfarcand force-pushed the main branch 3 times, most recently from 20ead11 to 95be683 Compare October 14, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants