Implement IPlayerService/GetOwnedGames#28
Open
ilumos wants to merge 4 commits intoAstrotomic:mainfrom
Open
Conversation
Gummibeer
reviewed
Jan 30, 2026
|
|
||
| public function defaultQuery(): array | ||
| { | ||
| return array_filter([ |
Member
There was a problem hiding this comment.
array_filter() will remove all falsy values which is false as well - so should do an explicit === null check in the callback.
Gummibeer
requested changes
Jan 30, 2026
Member
Gummibeer
left a comment
Gummibeer
left a comment
There was a problem hiding this comment.
please fix the array_filter() call
ilumos
commented
Jan 30, 2026
| 'include_extended_appinfo' => $this->include_extended_appinfo, | ||
| 'include_played_free_games' => $this->include_played_free_games, | ||
| ], | ||
| fn($value) => $value !== null |
Contributor
Author
There was a problem hiding this comment.
Added explicit null check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
IPlayerService/GetOwnedGames.Please let me know any changes I should make. Thanks :)