Updated to formatting, syntax & noting [Minor]#740
Open
MartinezDeveloper wants to merge 1 commit intoAsYetUntitled:v5.X.Xfrom
MartinezDeveloper:patch-1
Open
Updated to formatting, syntax & noting [Minor]#740MartinezDeveloper wants to merge 1 commit intoAsYetUntitled:v5.X.Xfrom MartinezDeveloper:patch-1
MartinezDeveloper wants to merge 1 commit intoAsYetUntitled:v5.X.Xfrom
MartinezDeveloper:patch-1
Conversation
Updated the parameter function to the newer and faster version Updated the private to the newer and faster version Noted all the currently vehicles in the list
mavrickthiry
approved these changes
Nov 18, 2020
that-edward
reviewed
Nov 18, 2020
| private ["_vehicle","_veh"]; | ||
| _vehicle = [_this,0,objNull,[objNull]] call BIS_fnc_param; | ||
|
|
||
| params [["_vehicle", objNull, [objNull]]; |
Contributor
There was a problem hiding this comment.
Your params is broken
params [["_vehicle", objNull, [objNull]];
should be
params [ ["_vehicle", objNull, [objNull]] ];
Contributor
|
And also afaik v5 is reserved for bug fixes, not new features or other things. But I'd like to have one of the maintainers comment on this for reassurance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the parameter function to the newer and faster version
Updated the private to the newer and faster version
Noted all the currently vehicles in the list