feat(tests, debugger): testing the debugger triggering on errors

Author: SuperFola

include/Ark/VM/Debugger.hpp

@@ -87,8 +87,9 @@ namespace Ark::internal
          *
          * @param vm
          * @param context
+         * @param from_breakpoint true if the debugger is being invoked from a breakpoint
          */
-        void run(VM& vm, ExecutionContext& context);
+        void run(VM& vm, ExecutionContext& context, bool from_breakpoint);
 
         [[nodiscard]] inline bool isRunning() const noexcept
         {

src/arkreactor/VM/Debugger.cpp

@@ -57,9 +57,10 @@ namespace Ark::internal
         m_states.pop_back();
     }
 
-    void Debugger::run(VM& vm, ExecutionContext& context)
+    void Debugger::run(VM& vm, ExecutionContext& context, const bool from_breakpoint)
     {
-        showContext(vm, context);
+        if (from_breakpoint)
+            showContext(vm, context);
 
         m_running = true;
         const bool is_vm_running = vm.m_running;

src/arkreactor/VM/VM.cpp

@@ -1200,7 +1200,7 @@ namespace Ark
                             if (m_state.m_features & FeatureVMDebugger && breakpoint_active)
                             {
                                 initDebugger(context);
-                                m_debugger->run(*this, context);
+                                m_debugger->run(*this, context, /* from_breakpoint= */ true);
                                 m_debugger->resetContextToSavedState(context);
 
                                 if (m_debugger->shouldQuitVM())
@@ -2306,7 +2306,7 @@ namespace Ark
         if (m_debugger && !error_from_debugger)
         {
             m_debugger->resetContextToSavedState(context);
-            m_debugger->run(*this, context);
+            m_debugger->run(*this, context, /* from_breakpoint= */ false);
         }
 
 #ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION

tests/unittests/Suites/DebuggerSuite.cpp

@@ -37,7 +37,7 @@ ut::suite<"Debugger"> debugger_suite = [] {
                 {
                     Ark::VM vm(state);
                     vm.usePromptFileForDebugger(prompt_path.generic_string(), os);
-                    vm.run(/* fail_with_exception= */ true);
+                    vm.run(/* fail_with_exception= */ false);
 
                     const std::string output = sanitizeOutput(os.str());
                     expectOrDiff(data.expected, output);

tests/unittests/resources/DebuggerSuite/modify_program_state.expected

@@ -13,7 +13,8 @@ In file tests/unittests/resources/DebuggerSuite/modify_program_state.ark:3
     4 |   (prn (format "ark: i={}" i))
     5 |   (set i (+ 1 i)) })
 
-dbg[pp:0,ip:32]:000> (print i)
+dbg[pp:0,ip:32]:000> (prn i)
+6
 nil
 dbg[pp:0,ip:32]:001> c
 dbg: continue

tests/unittests/resources/DebuggerSuite/modify_program_state.prompt

@@ -1,4 +1,4 @@
-(print i)
+(prn i)
 c
 (set i 20)
 c

tests/unittests/resources/DebuggerSuite/on_error.ark

@@ -0,0 +1,2 @@
+(let a 5)
+(prn (@ a 0))

tests/unittests/resources/DebuggerSuite/on_error.expected

@@ -0,0 +1,8 @@
+dbg[pp:0,ip:12]:000> (prn a)
+5
+nil
+dbg[pp:0,ip:12]:001> (prn (type a))
+Number
+nil
+dbg[pp:0,ip:12]:002> c
+dbg: continue

tests/unittests/resources/DebuggerSuite/on_error.prompt

@@ -0,0 +1,3 @@
+(prn a)
+(prn (type a))
+c