chore: addressing cppcheck recommandations: more ranges, less variable shadowing

Author: SuperFola

include/Ark/State.hpp

@@ -128,11 +128,6 @@ namespace Ark
          */
         void extendBytecode(const std::vector<bytecode_t>& pages, const std::vector<std::string>& symbols, const std::vector<Value>& constants);
 
-        [[nodiscard]] inline const bytecode_t& bytecode() const noexcept
-        {
-            return m_bytecode;
-        }
-
         friend class VM;
         friend class Repl;
         friend class internal::Closure;

src/arkreactor/Compiler/Lowerer/ASTLowerer.cpp

@@ -21,13 +21,11 @@ namespace Ark::internal
 
     void ASTLowerer::addToTables(const std::vector<std::string>& symbols, const std::vector<ValTableElem>& constants)
     {
-        for (const std::string& sym : symbols)
-            m_symbols.emplace_back(sym);
-        for (const ValTableElem& elem : constants)
-            m_values.emplace_back(elem);
+        std::ranges::copy(symbols, std::back_inserter(m_symbols));
+        std::ranges::copy(constants, std::back_inserter(m_values));
     }
 
-    void ASTLowerer::offsetPagesBy(std::size_t offset)
+    void ASTLowerer::offsetPagesBy(const std::size_t offset)
     {
         m_start_page_at_offset = offset;
     }

src/arkreactor/VM/Debugger.cpp

@@ -14,16 +14,23 @@
 namespace Ark::internal
 {
     Debugger::Debugger(const ExecutionContext& context, const std::vector<std::filesystem::path>& libenv, const std::vector<std::string>& symbols, const std::vector<Value>& constants) :
-        m_libenv(libenv), m_symbols(symbols), m_constants(constants), m_os(std::cout), m_colorize(true)
+        m_libenv(libenv),
+        m_symbols(symbols),
+        m_constants(constants),
+        m_os(std::cout),
+        m_colorize(true)
     {
         saveState(context);
     }
 
     Debugger::Debugger(const std::vector<std::filesystem::path>& libenv, const std::string& path_to_prompt_file, std::ostream& os, const std::vector<std::string>& symbols, const std::vector<Value>& constants) :
-        m_libenv(libenv), m_symbols(symbols), m_constants(constants), m_os(os), m_colorize(false)
-    {
-        m_prompt_stream = std::make_unique<std::ifstream>(path_to_prompt_file);
-    }
+        m_libenv(libenv),
+        m_symbols(symbols),
+        m_constants(constants),
+        m_os(os),
+        m_colorize(false),
+        m_prompt_stream(std::make_unique<std::ifstream>(path_to_prompt_file))
+    {}
 
     void Debugger::saveState(const ExecutionContext& context)
     {