chore: use const vector& when loading lambdas into Ark::State

Author: SuperFola

.github/workflows/static_analysis.yml

@@ -42,7 +42,7 @@ jobs:
           cppcheck --platform=unix64 --template="{file}:{line}: {severity}: {message}" \
             --output-file=cppcheck.txt \
             -I include src \
-            --enable=all --inline-suppr \
+            --enable=all --inline-suppr --check-level=exhaustive \
             --suppressions-list=cppcheck-suppressions.txt
           content=$(python .github/generate_cppcheck_report.py $(echo $(git diff --name-only -r HEAD^1 HEAD)))
           echo "CPPCHECK_REPORT<<EOF" >> $GITHUB_ENV

src/arkscript/REPL/Repl.cpp

@@ -121,11 +121,11 @@ namespace Ark
 
     void Repl::registerBuiltins()
     {
-        m_state.loadFunction("repl:history", [this]([[maybe_unused]] std::vector<Value>&, [[maybe_unused]] VM*) {
+        m_state.loadFunction("repl:history", [this]([[maybe_unused]] const std::vector<Value>&, [[maybe_unused]] VM*) {
             return Value(m_code);
         });
 
-        m_state.loadFunction("repl:save", [this](std::vector<Value>& n, [[maybe_unused]] VM*) {
+        m_state.loadFunction("repl:save", [this](const std::vector<Value>& n, [[maybe_unused]] VM*) {
             if (!types::check(n, ValueType::String))
                 throw types::TypeCheckingError(
                     "repl:save",
@@ -137,7 +137,7 @@ namespace Ark
             return Nil;
         });
 
-        m_state.loadFunction("repl:load", [this](std::vector<Value>& n, [[maybe_unused]] VM*) {
+        m_state.loadFunction("repl:load", [this](const std::vector<Value>& n, [[maybe_unused]] VM*) {
             if (!types::check(n, ValueType::String))
                 throw types::TypeCheckingError(
                     "repl:load",

tests/unittests/Suites/DebuggerSuite.cpp

@@ -18,8 +18,7 @@ ut::suite<"Debugger"> debugger_suite = [] {
             std::stringstream os;
             Ark::State state({ lib_path });
 
-            // cppcheck-suppress constParameterReference
-            state.loadFunction("prn", [&os](std::vector<Ark::Value>& args, Ark::VM* vm) -> Ark::Value {
+            state.loadFunction("prn", [&os](const std::vector<Ark::Value>& args, Ark::VM* vm) -> Ark::Value {
                 for (const auto& value : args)
                     fmt::print(os, "{}", value.toString(*vm));
                 fmt::println(os, "");