Conversation
- Fix-up some formatting. - Fix warning about using `Lock` for .NET 10+.
There was a problem hiding this comment.
Pull request overview
This PR focuses on small C# formatting cleanups in test utilities and tests, and introduces a conditional Lock type usage in FakeTelemetryListener to address .NET 10+ locking guidance/warnings while keeping older TFMs compatible.
Changes:
- Use target-typed
new(...)construction inTestUtilities.AsObjectArguments. - Add conditional
Lockaliasing for non-.NET10 TFMs and update_syncRoottype accordingly. - Add trailing commas in a few switch expressions / collection-like initializers to match formatting conventions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Polly.TestUtils/TestUtilities.cs | Minor formatting change to use target-typed new when constructing telemetry arguments. |
| test/Polly.TestUtils/FakeTelemetryListener.cs | Introduces conditional Lock usage for .NET 10+ and adjusts sync root type. |
| test/Polly.Core.Tests/Issues/IssuesTests.HandleMultipleResults_898.cs | Formatting tweak (adds trailing comma). |
| test/Polly.Core.Tests/Hedging/Controller/TaskExecutionTests.cs | Formatting tweak (adds trailing comma). |
| test/Polly.Core.Tests/Hedging/Controller/HedgingExecutionContextTests.cs | Formatting tweak (adds trailing comma). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 310 310
Lines 7135 7135
Branches 1005 1005
=======================================
Hits 6861 6861
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lockfor .NET 10+.