[Postgres Support 1/5] Build/CI & Core Data Type Fixes#1265
Open
minguyen9988 wants to merge 3 commits into2.9.1from
Open
[Postgres Support 1/5] Build/CI & Core Data Type Fixes#1265minguyen9988 wants to merge 3 commits into2.9.1from
minguyen9988 wants to merge 3 commits into2.9.1from
Conversation
minguyen9988
force-pushed
the
minguyen/postgres-pr1-build-ci-datatype-fixes
branch
from
040eaae to
2bb1041
Compare
minguyen9988
force-pushed
the
minguyen/postgres-pr1-build-ci-datatype-fixes
branch
from
2bb1041 to
4be0808
Compare
Cherry-pick ClickHouseAutoCreateTable.java from minguyen/postgres to remove NULL/NOT NULL modifiers when types are already Nullable(). Add ColumnTypeOverrideReconciler and ColumnTypeOverrideMismatchException dependencies. Update test expectations to match new DDL output.
The JDBC getMetaData().getColumns() approach does not properly filter by database in ClickHouse (databases map to catalogs, not schemas), causing testGetColumnsDataTypesForTable to fail. Restore the system.columns direct query approach from minguyen/postgres which correctly filters by database and table name, and preserves the Nullable() wrapper in type names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build configuration fixes and core data type mapping improvements for PostgreSQL support.
Part 1 of 5 PRs split from #1245 for reviewability.
Changes
testSourceDirectorypath (wassrc/test, nowsrc/test/java) — fixesSecurityException: Prohibited package name'UTC'timezone to prevent DST corruptionTIMESTAMPTZ,TIMETZ,UUID,BYTEA,JSONB,SERIAL/BIGSERIAL,TEXT,CHARACTER VARYING,BOOLEAN,NUMERIC/DECIMALwith precisionFiles (15 files, +489/−57)
sink-connector/pom.xmlsink-connector/src/main/java/com/altinity/clickhouse/sink/connector/converters/ClickHouseDataTypeMapper.javasink-connector/src/test/java/.../ClickHouseDataTypeMapperDDLTest.javasink-connector/src/test/java/.../ClickHouseTableOperationsBaseTest.java.github/workflows/CI configsReview Notes