Skip to content

Conversation

@baasingh
Copy link
Contributor

@baasingh baasingh commented Jan 8, 2026

  • Subscribe required table in the process function,
  • To fix linters code name need to change.
  • Fix all the linters which were not done in the previous: https://github.com/AliceO2Group/O2Physics/pull/14042

@github-actions github-actions bot added the pwgcf label Jan 8, 2026
@github-actions github-actions bot changed the title PWGCF/EbyE: Fixing process() and all the linters [PWGCF/EbyE] Fixing process() and all the linters Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@vkucera vkucera marked this pull request as draft January 9, 2026 06:45
@vkucera
Copy link
Collaborator

vkucera commented Jan 9, 2026

@baasingh Don't open your PR as ready for review if it doesn't pass required checks.

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

Why did you give the file a wrong name in 47c6de8?

@baasingh
Copy link
Contributor Author

Hi @vkucera, thank you so much for the reply.
I was trying to fix all the linter issues, one of which was the code name, so II did this PR:
33a4c66
but it gave errors for other workflow names.

Now, i tried to revert back in this: 47c6de8

I am not able to comprehend the issue.

Thanks,
Balwan

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

Which remaining issues are you trying to fix exactly?

@baasingh
Copy link
Contributor Author

I was asked in my previous PR to fix the linter issues (https://github.com/AliceO2Group/O2Physics/pull/14042#pullrequestreview-3580503130)

Now, there is one left linter issue,
when I run the command:
python3 Scripts/o2_linter.py PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx
i get: PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:1: warning: Use lowerCamelCase or UpperCamelCase for names of C++ files. See the O2 naming conventions for details. [name/file-cpp]

Results for failed, tolerated and disabled tests

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

But that's the one you just introduced with your last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants