Skip to content

Conversation

@subhangi2731
Copy link
Contributor

Description

added Inline JS support to ESlint

Fixes #518

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@subhangi2731
Copy link
Contributor Author

@harikesh409 @ravikr126 please merge my pr I have done

Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated linting is not done properly do the required changes.

@subhangi2731
Copy link
Contributor Author

@harikesh409 I will do the changes bu tomorrow will I get scores for this and can u merge as I send the pr before may 31??

@subhangi2731
Copy link
Contributor Author

@harikesh409 @ravikr126 I have done all the changes as told by u and have rectified everything please merge my pr by tomorrow

@harikesh409
Copy link
Collaborator

harikesh409 commented Jun 4, 2021

Resolve merge conflicts and also a blank line addition is present on readme file remove that also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To add inline JS support to eslint

2 participants