Open
Conversation
This reverts commit 058bc4f. the html will be regenerated before the next A1 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR basically adds 2 subtables to the Music lua table, Sequence & Segment. It also adds a new MusicFadeType enumeration to provide different fading functions even if for now only 2 are available (or 3 if we count the seamless transition)
Here is a music plugin using the new multiple lua plugins feature to demonstrate a simple case with the new api in use and how it behaves in game. Which will probably be easier to review than the PR to see how it works.
In it, only one music channel is used with 4 sequences:
All segment transitions are seamless transitions except the ones that lead to the dead sequence which use crossfades transition.
SegmentedMusic.zip
I also updated the xslt because I wanted the "new" functions for the subtables to be placed first in the documentation and sorting by name as it does now, was preventing that.