This repository was archived by the owner on Apr 19, 2024. It is now read-only.
Fix bug when deal with input value of uint.#483
Open
hustclf wants to merge 1 commit intoAlecAivazis:masterfrom
Open
Fix bug when deal with input value of uint.#483hustclf wants to merge 1 commit intoAlecAivazis:masterfrom
uint.#483hustclf wants to merge 1 commit intoAlecAivazis:masterfrom
Conversation
Owner
|
Awesome! Thanks for putting this together. Do you mind adding a test that confirms the behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, guys, there is a bug when parsing input unit value larger than 255.
here is a example to reproduce the bug.
And we should set
bitSizeto 0 when callingparseUint, which means let the operating system determine the appropriatebitSize.