Performance issue due to adding popper classes to body on page with large number of DOM nodes#1019
Open
huynhtehoa wants to merge 1 commit intoAkryum:mainfrom
Open
Performance issue due to adding popper classes to body on page with large number of DOM nodes#1019huynhtehoa wants to merge 1 commit intoAkryum:mainfrom
huynhtehoa wants to merge 1 commit intoAkryum:mainfrom
Conversation
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a page contains a large number of DOM nodes, toggling floating elements becomes very slow. This happens because
floating-vueis adding/removing classes directly onbody, which triggers reflowing that affects a lot of nodesThis is extremely impactful, especially in analytics application that renders tables with many cells
I do not see that these added classes are used anywhere so I guess they are either legacy or for customization ability
Using the Egdge performance tool, we could see that


$_applyShowand$_applyHideare affecting many elements during the style recalculation phaseSolution
addPopperClassesToBodyoption to disable the adding-popper-classes-to-body behavior