Fixes div by zero. Adds FPE to tests. #2093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrbailey
reviewed
Sep 25, 2025
Idclip
reviewed
Sep 26, 2025
stolk
force-pushed
the
fpe
branch
2 times, most recently
from
5d72ffd to
df7aa5d
Compare
Author
|
Can someone please approve workflows? Also, I've addressed the MR feedback, I think this is ready to get merged. |
Author
|
Hello, this MR solves real bugs, and I have revised the MR according to feedback. Can one of you please approve the MR? Thanks. |
danrbailey
reviewed
Nov 8, 2025
stolk
changed the title
Author
|
Ping |
danrbailey
requested changes
Jan 7, 2026
To catch FP exceptions, build as: $ cmake -D OPENVDB_TESTS_FPE=ON ... And to get callstacks in debugger, use: $ gdb --args ./openvdb/openvdb/unittest/vdb_test --gtest_catch_exceptions=0 This toggle will let you reproduce issues AcademySoftwareFoundation#2090 AcademySoftwareFoundation#2091 AcademySoftwareFoundation#2092 Signed-off-by: Bram Stolk <b.stolk@gmail.com>
FIXES AcademySoftwareFoundation#2091 Signed-off-by: Bram Stolk <b.stolk@gmail.com>
stolk
changed the title
stolk
changed the title
danrbailey
approved these changes
Jan 10, 2026
Contributor
danrbailey
left a comment
danrbailey
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for making those changes. We'll try and get this merged in soon.
jmlait
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a toggle to run the vbe_test program with FP exceptions enabled.
This MR also fixes issues #2090 #2091 #2092 that were found with this facility:This MR also fixes a division by zero.